Double oops. Drat! I was not looking at the branch johnnyt/improved_installer. Still need to check whether tar xfz works on all platforms.

— Monty

On Jan 18, 2015, at 9:29 AM, Monty Williams [email protected] wrote:

Oops. I was looking at diffs not the final file. This must have been changed back to using gunzip.

On Jan 18, 2015, at 9:16 AM, Monty Williams <[email protected] mailto:[email protected]> wrote:

Thanks to @johnnyt & @mpapis for all the work! Glad to see it’s finally implemented after so many years of waiting.

Has anyone checked on Solaris? In particular does tar xfz work? Maybe it was AIX that caused me to use gunzip -c $gss_file | tar xf -

Cheers,
Monty

On Jan 17, 2015, at 10:36 PM, JohnnyT <[email protected] mailto:[email protected]> wrote:

@mpapis https://github.com/mpapis @Monty https://github.com/Monty @timfel https://github.com/timfel - this is finally working.

What do you guys think?

This closes #195 #195
You can view, comment on, or merge this pull request online at:

#370 #370
Commit Summary

separate valiation and setup steps from install process
proof of concept: allow configuring destination and used paths, cleaned code style
remove root check from setup.sh, it's allowed this time
forward install.sh parameters to update.sh
formating + improve the platform check
allow running stwrappers, restore rake, move copy to the optimal location, do not use rake for start
cleaning and formating setup.sh
translate rake tasks to shell
make sure important steps are executed, fail otherwise
fix Gemstone VM name for download
fix Gemstone VM name for download
make sure all helpers are loaded
changes from @timfel
improve error reporting for build_maglev
allow specifying stonename and make sure it persist for update
improved error reporting for command run in stone
just reordering functions
improve the process, add --help
show last 10 lines of the log on error
fix build_maglev_in_stone finalizing and return status
increase log output to 50 lines in case of errors
improve logging and outputs for build_maglev_in_stone
Fix merge conflicts in update.sh
Uses gemtalksystems.com http://gemtalksystems.com/ for GSS download
Fixes merge conflicts
Changes GemStone versions directory
Changes gss_file to filename only; cd into versions directory before download
🚫 Ignores versions directory
🚫 Ignores RubyGems directory
Runs topaz as a linked session
Changes mkdir_p to mkdir -p
Removes config file args - they are set as ENV vars
Changes STONE_NAME to STONENAME
Fixes outfile assignment
🚫 Ignores .stonename
Fixes MAGLEV_HOME var in loadfiletree.gs
Uses loadfiletree.gs instead of inlining
File Changes

M .gitignore https://github.com/MagLev/maglev/pull/370/files#diff-0 (3)
A build_functions.sh https://github.com/MagLev/maglev/pull/370/files#diff-1 (208)
M install.sh https://github.com/MagLev/maglev/pull/370/files#diff-2 (218)
A setup.sh https://github.com/MagLev/maglev/pull/370/files#diff-3 (178)
M src/smalltalk/loadfiletree.gs https://github.com/MagLev/maglev/pull/370/files#diff-4 (2)
M update.sh https://github.com/MagLev/maglev/pull/370/files#diff-5 (346)
A validate.sh https://github.com/MagLev/maglev/pull/370/files#diff-6 (50)
Patch Links:

https://github.com/MagLev/maglev/pull/370.patch https://github.com/MagLev/maglev/pull/370.patch
https://github.com/MagLev/maglev/pull/370.diff https://github.com/MagLev/maglev/pull/370.diff
—
Reply to this email directly or view it on GitHub #370.

@Monty @AllenOtis - I couldn't see any builds for Solaris at http://seaside.gemtalksystems.com/maglev/
should there be any listed there?

No. Only Mac & Linux. I was thinking of the install script for GemStone/S which also needs Solaris & AIX. MagLev scripts don't actually need to run on those platforms. 

I was confused because some of the shell scripts used to be shared. 

— Monty

Sent from Mailbox for iPad

On Mon, Jan 19, 2015 at 6:43 AM, JohnnyT [email protected] wrote:

@Monty @AllenOtis - I couldn't see any builds for Solaris at http://seaside.gemtalksystems.com/maglev/

should there be any listed there?

Reply to this email directly or view it on GitHub:
#370 (comment)

I'd like to get this merged in if we can - @mpapis - what do you think? Have you had any time to try it out / look it over?

no I did not had time to look into it, will try to find time for review but it might get merged sooner - then I will work on integrating the new installer into RVM and review during it

I'm sorry but I probably wont have time to review - please don't wait for me

@jc00ke - This is finally ready to merge

I'll take a look now, and if nothing jumps out I'll merge.

Thoughts on log_info, log_warn and log_error functions that will add some color to the output?

Colored logging would be nice - I just created issue #376 for that.

@jc00ke how does this look? I'd love to get this merged in so we can get working on the parser.

Cool, let's get to that parser!